add azure blob config to chart#89
Merged
Merged
Conversation
mekilis
reviewed
Jun 24, 2026
mekilis
left a comment
Contributor
There was a problem hiding this comment.
Before merge, run helm template with env.storage.enabled=true and env.storage.type=azure_blob, once with inline account_key and once with secret, to confirm both branches render. Env var names match the server's config.go and the type goes through the existing CONVOY_STORAGE_POLICY_TYPE, so this is just a formality.
ca36b26 to
6769139
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes how cloud storage credentials are injected at deploy time; Azure adopters must use Secret key
accountKeyor upgrades fromextraEnvs/account_keycan fail silently on missing credentials.Overview
Adds first-class Azure Blob object storage to the Convoy Helm chart for server and agent (Deployment and Rollout templates), driven by
storage.type: azure_bloband newstorage.azure_blob.*values that map toCONVOY_STORAGE_AZURE_*environment variables.Account keys can be set inline or via an existing Secret (
storage.azure_blob.secret), with the Secret keyaccountKey(documented separately from S3’ssecretKey). README /README.md.gotmpladd an Object Storage section with examples and an upgrade note for teams moving offextraEnvswho may still haveaccount_keyin their Secret.S3 wiring is tightened on the server side: optional
storage.s3.prefixis emitted asCONVOY_STORAGE_AWS_PREFIX, and the S3 secret reference guard matches the agent pattern (and+ non-empty check). Defaultvalues.yamland subchart values gain matchingazure_blob(and agents3.prefix) blocks; generated README values table reflects the new fields.Reviewed by Cursor Bugbot for commit 6769139. Bugbot is set up for automated code reviews on this repo. Configure here.