Skip to content

add azure blob config to chart#89

Merged
olamilekan000 merged 1 commit into
mainfrom
add-azure-blob-config
Jun 30, 2026
Merged

add azure blob config to chart#89
olamilekan000 merged 1 commit into
mainfrom
add-azure-blob-config

Conversation

@olamilekan000

@olamilekan000 olamilekan000 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor
change add azure blob config to chart

Note

Medium Risk
Changes how cloud storage credentials are injected at deploy time; Azure adopters must use Secret key accountKey or upgrades from extraEnvs/account_key can fail silently on missing credentials.

Overview
Adds first-class Azure Blob object storage to the Convoy Helm chart for server and agent (Deployment and Rollout templates), driven by storage.type: azure_blob and new storage.azure_blob.* values that map to CONVOY_STORAGE_AZURE_* environment variables.

Account keys can be set inline or via an existing Secret (storage.azure_blob.secret), with the Secret key accountKey (documented separately from S3’s secretKey). README / README.md.gotmpl add an Object Storage section with examples and an upgrade note for teams moving off extraEnvs who may still have account_key in their Secret.

S3 wiring is tightened on the server side: optional storage.s3.prefix is emitted as CONVOY_STORAGE_AWS_PREFIX, and the S3 secret reference guard matches the agent pattern (and + non-empty check). Default values.yaml and subchart values gain matching azure_blob (and agent s3.prefix) blocks; generated README values table reflects the new fields.

Reviewed by Cursor Bugbot for commit 6769139. Bugbot is set up for automated code reviews on this repo. Configure here.

@olamilekan000 olamilekan000 enabled auto-merge (squash) June 24, 2026 01:35

@mekilis mekilis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merge, run helm template with env.storage.enabled=true and env.storage.type=azure_blob, once with inline account_key and once with secret, to confirm both branches render. Env var names match the server's config.go and the type goes through the existing CONVOY_STORAGE_POLICY_TYPE, so this is just a formality.

Comment thread charts/server/templates/deployment.yaml
Comment thread README.md
@olamilekan000 olamilekan000 force-pushed the add-azure-blob-config branch from ca36b26 to 6769139 Compare June 24, 2026 14:53
@olamilekan000 olamilekan000 requested a review from mekilis June 24, 2026 14:53

@mekilis mekilis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@olamilekan000 olamilekan000 merged commit 1e84287 into main Jun 30, 2026
3 checks passed
@olamilekan000 olamilekan000 deleted the add-azure-blob-config branch June 30, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants